Added a warning for CLI mode if env TZ is not set.#384
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a warning that displays in CLI mode when the environment variable TZ is not set. The warning tells the user that performance may be impacted and encourages them to set the variable. If TZ is set the set timezone will be output.
The portability of this needs to be checked on windows systems running the CLI.
Setting the TZ variable positivity impacts performance on systems where the call to mktime() in StandardConverterUtility::Calculate_TdateTime_Offset and StandardConverterUtility::EncodeDateTime ends up calling the system utility tzset which uses the TZ environment variable.
This implementation may not be good for all systems.